Skip to content
This repository has been archived by the owner on Jan 25, 2021. It is now read-only.

Added an option to unauthorize all previously authotized users. #18

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

operez-ddgi
Copy link

It will be useful when clearing census data.
In current master branch when a user gets authorized it is authorized for live. If he leaves town he can still participate in areas where maybe he should not.
With this option a checkbox appears on the upload census screen allowing the admin to remove all previous authorizations.

@operez-ddgi
Copy link
Author

Hello @xredo , I added an option to clear organization's authorizations. Our multitenant clients need this option and I thought it could be interesting to somebody else...

@xredo
Copy link
Member

xredo commented Dec 7, 2018

Hi @operez-ddgi

Thank you for opening the PR. We are waiting to merge the PR #19 that updates the gem to the latest Decidim version to start this review.

After we merge #19 we are planning to support different Decidim versions with this gem. Please, let us know if there is any problem with it.

@operez-ddgi
Copy link
Author

Hi @xredo ,

ok, as soon as PR #19 is merged, I'll test my PR and let you know.

Thank-you very much

@artero
Copy link
Member

artero commented Jan 15, 2019

Hi @operez-ddgi.

We have merged #19 to master. Can you rebase your branch with paster and push again, please?

…ll be useful when clearing census data

Clear authorizations now only for current organization

Corrected spacs problem

Updated Decidim dependency version

Moved clear authorizations action to its own method

Removed trailing whitespace

removed whitespaces and tabs

Uncommented lines and corrected whitespaces

Corrected indentation

Removed trailing whitespace

Corrected whitespaces and removed unnecessary code

Added a final newline

Added a final newline

Resolved conflicts

Resolved conflicts

Solved conflicts
@operez-ddgi
Copy link
Author

Hi @artero ,

I just rebased this PR.

Thank-you very much

Copy link
Member

@artero artero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added some comments. Could you review them and tell me what do you think? Thanks for the PR!

@operez-ddgi
Copy link
Author

Hi @artero ,

I reviewed all your comments and pushed a new version. Could you please check it again?

Thank-you very much

Copy link
Member

@artero artero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a couple minor comments.

Thank you so much for the PR.

@@ -1,45 +1,46 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, could you remove this line, please

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops! This line shbould not be there! Thank-you for pointing it!

lib/decidim/file_authorization_handler/admin_engine.rb Outdated Show resolved Hide resolved
@operez-ddgi
Copy link
Author

Thank-you very much @artero for your reviews. Now I corrected these errors

Copy link
Member

@artero artero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants