Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow HTML in Toast content with allowUnsafeHtml props #332

Open
wants to merge 7 commits into
base: next
Choose a base branch
from
Open

Allow HTML in Toast content with allowUnsafeHtml props #332

wants to merge 7 commits into from

Conversation

mrleblanc101
Copy link

@mrleblanc101 mrleblanc101 commented May 6, 2022 •
edited

Description

Allow HTML in Toast content

Related Issue

#248 , #315

Screenshots or GIFs (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mrleblanc101 mrleblanc101 changed the title [FIX] Allow HTML in Toast content Draft: [FIX] Allow HTML in Toast content May 6, 2022
@mrleblanc101 mrleblanc101 changed the title Draft: [FIX] Allow HTML in Toast content wip: [FIX] Allow HTML in Toast content May 6, 2022
@mrleblanc101 mrleblanc101 marked this pull request as draft May 6, 2022 18:48
@mrleblanc101 mrleblanc101 changed the title wip: [FIX] Allow HTML in Toast content [FIX] Allow HTML in Toast content May 6, 2022
@mrleblanc101 mrleblanc101 marked this pull request as ready for review May 6, 2022 19:11
@mrleblanc101 mrleblanc101 changed the title [FIX] Allow HTML in Toast content Allow HTML in Toast content with allowUnsafeHtml props May 6, 2022
fuzemobi
fuzemobi approved these changes Jan 12, 2023
View reviewed changes
Copy link

@fuzemobi fuzemobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code changes are clean and add much needed functionality to this component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuzemobi fuzemobi fuzemobi approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrleblanc101 @fuzemobi