Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separated nonEmptyCheckoutView from Checkout.js #28

Merged
merged 5 commits into from Apr 23, 2019

Conversation

RobertZetterlund
Copy link
Collaborator

@RobertZetterlund RobertZetterlund commented Apr 21, 2019

Also, added tests, but cannnot execute them because of jest-babel error. Jest verkar inte vilja acceptera StyleSheet eftersom det inte är JS... förmodligen ska man följa detta

jestjs/jest#6933

eller

https://jestjs.io/docs/en/configuration.html

men tbh struggling. Men återkommer imorgon 😄

Resolved genom preset i package.json

@RobertZetterlund RobertZetterlund added enhancement help wanted Extra attention is needed Tests Tests for a feature labels Apr 21, 2019
@MarkusPettersson98
Copy link
Owner

MarkusPettersson98 commented Apr 21, 2019

Codecov Report

Merging #28 into dev will decrease coverage by 16.2%.
The diff coverage is 57.14%.

Impacted file tree graph

@@           Coverage Diff           @@
##             dev   #28       +/-   ##
=======================================
- Coverage   86.2%   70%   -16.21%     
=======================================
  Files          6    16       +10     
  Lines         58   110       +52     
  Branches       6     8        +2     
=======================================
+ Hits          50    77       +27     
- Misses         6    30       +24     
- Partials       2     3        +1
Impacted Files Coverage Δ
App/pages/components/checkout/TotalAmount.js 66.66% <ø> (ø)
App/pages/components/checkout/pickUpPointView.js 50% <ø> (ø)
App/pages/components/dummy-data.js 100% <100%> (ø)
App/pages/components/checkout/NonEmptyCheckout.js 47.05% <47.05%> (ø)
App/pages/components/resources/linsen.jpg 100% <0%> (ø)
App/pages/components/checkout/OrderButton.js 75% <0%> (ø)
App/pages/components/resources/biblan.jpg 100% <0%> (ø)
App/pages/components/resources/bulten.jpg 100% <0%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e00d655...c101ef7. Read the comment docs.

@RobertZetterlund RobertZetterlund removed the help wanted Extra attention is needed label Apr 22, 2019
Copy link
Owner

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bra ut, gött med mer tester!

@MarkusPettersson98 MarkusPettersson98 merged commit 8d117d2 into dev Apr 23, 2019
@MarkusPettersson98 MarkusPettersson98 deleted the App/checkout branch April 23, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tests Tests for a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants