Fixes expressjs#1233. Makes multer handle missing field names.

Markiz9999 · Apr 23, 2024 · e0c4ae3 · e0c4ae3
1 parent ddb65bd
commit e0c4ae3
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/lib/make-middleware.js b/lib/make-middleware.js
@@ -87,6 +87,8 @@ function makeMiddleware (setup) {
 
     // handle files
     busboy.on('file', function (fieldname, fileStream, { filename, encoding, mimeType }) {
+      if (fieldname == null) return abortWithCode('MISSING_FIELD_NAME')
+
       // don't attach to the files object, if there is no file
       if (!filename) return fileStream.resume()
 

diff --git a/test/error-handling.js b/test/error-handling.js
@@ -175,6 +175,19 @@ describe('Error Handling', function () {
     })
   })
 
+  it('should notify of missing field name', function (done) {
+    var form = new FormData()
+    var storage = multer.memoryStorage()
+    var parser = multer({ storage: storage }).single('small0')
+
+    form.append('', util.file('small0.dat'))
+
+    util.submitForm(parser, form, function (err, req) {
+      assert.strictEqual(err.code, 'MISSING_FIELD_NAME')
+      done()
+    })
+  })
+
   it('should report errors from storage engines', function (done) {
     var storage = multer.memoryStorage()