Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved issue #40 #70

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Solved issue #40 #70

merged 4 commits into from
Oct 23, 2023

Conversation

infopz
Copy link
Contributor

@infopz infopz commented Sep 27, 2023

Solved issue #40.
When two true entities were predicted as one, the classification differs based on the input list order

@ivyleavedtoadflax
Copy link
Collaborator

Thanks for this @infopz . Are you able to add a test for this please 🙏

@infopz
Copy link
Contributor Author

infopz commented Sep 28, 2023

Test added 👍

@ivyleavedtoadflax
Copy link
Collaborator

@infopz can you merge #71 into this, to see if it resolves the failing CI/CD please

@infopz
Copy link
Contributor Author

infopz commented Oct 4, 2023

Merged 👍

@ivyleavedtoadflax ivyleavedtoadflax added the bug Something isn't working label Oct 17, 2023
@davidsbatista
Copy link
Collaborator

Thanks for contributing - there's a failing issue but I will look into it.

@infopz
Copy link
Contributor Author

infopz commented Oct 20, 2023

Hi, can I do something to fix this?

@davidsbatista
Copy link
Collaborator

I'm planning to do it at the weekend., but if you want please, go ahead :)

@infopz
Copy link
Contributor Author

infopz commented Oct 20, 2023

It seems a permission problem on your side
remote: Permission to MantisAI/nervaluate.git denied to github-actions[bot].
but if this depends on something I can do, feel free to ask

@davidsbatista
Copy link
Collaborator

The PR LGTM, it's just the issue with the CI/CD now - @ivyleavedtoadflax do you have any idea what might be causing that?

@ivyleavedtoadflax
Copy link
Collaborator

I believe it is failing because the PR is originating from a fork which defaults to read access, but the coverage action needs write access to push to the repo.

/usr/bin/git push --force ***github.com/MantisAI/nervaluate.git github-pages-deploy-action/pcenusi52:coverage-badge
remote: Permission to MantisAI/nervaluate.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/MantisAI/nervaluate.git/': The requested URL returned error: 403

I'll merge for now, and that will resolve it, but not sure the best way to resolve going forward.

@ivyleavedtoadflax ivyleavedtoadflax merged commit 0978d89 into MantisAI:main Oct 23, 2023
1 check failed
@ivyleavedtoadflax
Copy link
Collaborator

Could also be that we can set the pages permission to write as here https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs#defining-access-for-the-github_token-scopes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants