-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplifing the CI/CD process #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Just one query about the Makefile. Would be good to keep these recipes, and update them as appropriate.
PYTHON_VERSION = python3.8 | ||
VIRTUALENV := .venv | ||
|
||
.PHONY: virtualenv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd quite like to keep these recipes if we can because they do make life a lot easier. I think we definitely don't want to be managing requirements_dev.txt
manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can restore it for sure.
pytest
andcoverage
only instead of tox, since I think this lib is so simple - doesn't use any 3rd party libraries - running tests on a single python version should be fine, I propose 3.8NOTE: if this is OK I will then open another PR with an improved README.MD + some more examples on how to use the package
After it's approved we can also generate a new pip package + review the issues, I'm sure some will be closed/tackled.