Fix database connection using a socket on CI

[Fryguy]

No description provided.

[jrafanie]

bump, this is failing on multiple rubies with an invalid connection string... does this make sense?

  23) PG::LogicalReplication::Client with a subscription #alter_subscription_options changes the options provided by CREATE SUBSCRIPTION
      Failure/Error: result = connection.async_exec(sql, params, nil, self.class.type_map_for_queries(connection))

      PG::SyntaxError:
        ERROR:  invalid connection string syntax: invalid connection option "sslsni"
      # ./lib/pg/logical_replication/client.rb:356:in `exec'
      # ./lib/pg/logical_replication/client.rb:356:in `typed_exec'
      # ./lib/pg/logical_replication/client.rb:70:in `create_subscription'
      # ./spec/client_spec.rb:155:in `create_subscription'
      # ./spec/client_spec.rb:145:in `block (3 levels) in <top (required)>'
      # ./spec/client_spec.rb:14:in `block (3 levels) in <top (required)>'
      # ./spec/support/database_helper.rb:53:in `with_clean_environment'
      # ./spec/client_spec.rb:14:in `block (2 levels) in <top (required)>'

[Fryguy]

@jrafanie Yeah that's where I'm stuck...There's some other sort of setting I need

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[miq-bot]

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[miq-bot]

Some comments on commits Fryguy/pg-logical_replication@b3d147c~...a3f93bd

lib/pg/logical_replication/client.rb

• ⚠️ - 356 - Detected puts. Remove all debugging statements.
• ⚠️ - 357 - Detected puts. Remove all debugging statements.
• ⚠️ - 358 - Detected puts. Remove all debugging statements.

[miq-bot]

Checked commits Fryguy/pg-logical_replication@b3d147c~...a3f93bd with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
7 files checked, 13 offenses detected

Rakefile

• ❗ - Line 18, Col 18 - Rails/SquishedSQLHeredocs - Use <<-SQL.squish instead of <<-SQL.

**

• 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

lib/pg/logical_replication/client.rb

• ❗ - Line 356, Col 9 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.
• ❗ - Line 357, Col 9 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.
• ❗ - Line 358, Col 9 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.

spec/spec_helper.rb

• ⚠️ - Line 7, Col 1 - Lint/NonDeterministicRequireOrder - Sort files before requiring them.

spec/support/connection_helper.rb

• ⚠️ - Line 12, Col 32 - Lint/UnusedBlockArgument - Unused block argument - r. You can omit the argument if you don't care about it.
• ⚠️ - Line 18, Col 32 - Lint/UnusedBlockArgument - Unused block argument - r. You can omit the argument if you don't care about it.
• ❗ - Line 23, Col 5 - Style/ExplicitBlockArgument - Consider using explicit block argument in the surrounding method's signature over yield.
• ❗ - Line 4, Col 32 - Style/FetchEnvVar - Use ENV.fetch("POSTGRESQL_USER") or ENV.fetch("POSTGRESQL_USER", nil) instead of ENV["POSTGRESQL_USER"].
• ❗ - Line 4, Col 58 - Style/FetchEnvVar - Use ENV.fetch("POSTGRESQL_PASSWORD") or ENV.fetch("POSTGRESQL_PASSWORD", nil) instead of ENV["POSTGRESQL_PASSWORD"].
• ❗ - Line 4, Col 88 - Style/FetchEnvVar - Use ENV.fetch("POSTGRESQL_HOST") or ENV.fetch("POSTGRESQL_HOST", nil) instead of ENV["POSTGRESQL_HOST"].

spec/support/database_helper.rb

• ❗ - Line 5, Col 5 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].