formatters for JS charts

[himdel]

JS implementation of MiqReport::Formatting#format_*, meant to be used by code from #3894.

Curried so that we can say things like axis.x.tick.formatter = ManageIQ.charts.formatters.boolean({ format: 't_f' });. (ManageIQ.charts.formatters.number_with_delimiter({ precision: 3, separator: '!', delimiter: '@' })(123456.7891) yields "123@456!789").

TODO:

• remove the included yml fragments
• write tests
• fix test failures

Will do a separate PR addressing these issues later:

• ruby tests
• non-UTC time zone handling
• datetime_range should not look at description and probably not column suffix either
• test that we have the same functions in JS and Ruby

EDIT:
The date-related test failures will be gone after benjaminoakes/moment-strftime#15 .

[miq-bot]

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

[miq-bot]

<gemfile_checker />Gemfile changes detected in commits https://github.com/himdel/manageiq/compare/ddb185bc281a0869b077df7db6f5ace6cf227cca...dbd6847f2cb79950d10a699d1506f53f2c3f85c1. /cc @JPrause @simaishi

[miq-bot]

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

[himdel]

@martinpovolny depending on how the moment-strftime problem goes you may need to fix the version in the gemfile, but otherwise it should be ready

[dclarizio]

@martinpovolny There are some JS test failures, hopefully you can find someone to help fix them up while @himdel is out.

[himdel]

@dclarizio..They should be taken care of soon, it's just that the new release of moment-strftime included the old minified version instead of the new one (and rails assets picks just that file). (see the link in the top comment)

[martinpovolny]

@JPrause : are you ok with these gems' inclusion?

[martinpovolny]

Btw: thx! 🍻

[martinpovolny]

@himdel : One small problem: jqplot calls the formatter with an extra argument: formatter(format_string, value)

wherefor I need something like this:

  window.ManageIQ.charts.orig_formatters = _.mapValues(format, _.curryRight);
  window.ManageIQ.charts.formatters = _.mapValues(window.ManageIQ.charts.orig_formatters,
      function(fun) { return function(_x, val, opts) { return fun(val, opts) }})  

but again the curried version. Can you fix that for me? There's _.rearg and _.restParam but that looks just too complicated to me there must be some simpler way ;-)

[himdel]

I just wrote this.. but can't actually commit it because github&IE8...

Updated the ManageIQ.charts.formatters object so that you can pick between 3 function signatures:

• formatters.foo will take value and options and return the result directly
• formatters.foo.c3 will take options and return a function taking a value
• formatters.foo.jqplot will do the same except the resulting function ignores it first argument and works with the second

  // .foo(opt, val) or .foo.c3(opt)(val) or .foo.jqplot(opt)(_, val)
  window.ManageIQ.charts.formatters = _.mapValues(format, function(fn) {
    fn.c3 = _.curryRight(fn);

    fn.jqplot = function(opt) {
      return function(_fmt, val) {
        return fn(val, opt);
      };
    };

    return fn;
  });

EDIT: commited, fixed and added tests; still waiting for a new moment-strftime release

[himdel]

Tests failures fixed by a new moment-strftime release, ready for merging :)

[miq-bot]

Checked commits https://github.com/himdel/manageiq/compare/a09b208a3ee4bd28732e362d1e1d898e9352d1f3~...07a37d65103a3be39dac0977741dcb5cfb0ada2f with ruby 1.9.3, rubocop 0.33.0, and haml-lint 0.13.0
2 files checked, 0 offenses detected
Everything looks good. 🍰