Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MORPHY] Fix Contrast issue No Use Of Eval #9176

Merged
merged 1 commit into from
May 23, 2024
Merged

[MORPHY] Fix Contrast issue No Use Of Eval #9176

merged 1 commit into from
May 23, 2024

Conversation

jeffibm
Copy link
Member

@jeffibm jeffibm commented May 3, 2024 •
edited by Fryguy

Removing the usage of eval function inside afterOnLoad function.

@jeffibm jeffibm added the bug label May 3, 2024
GilbertCherrie
GilbertCherrie reviewed May 17, 2024
View reviewed changes
app/views/ops/explorer.html.haml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be: miqOpsAfterOnload()? I am hitting a console error: Uncaught ReferenceError: miqReportAfterOnload is not defined.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffibm I think the code didn't change from @GilbertCherrie 's last comment here so does it still apply?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before it was: miqReportAfterOnload so it looks good now. New code is using the same function as the old code now.

.yarn/install-state.gz Outdated Show resolved Hide resolved
@miq-bot
Copy link
Member

miq-bot commented May 22, 2024

Checked commit jeffbonson@8f6baff with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
14 files checked, 20 offenses detected

app/views/automation_manager/_inventory_group.html.haml

  • 💣 💥 🔥 🚒 - Line 0 - Couldn't process the file for linting. HamlLint::Exceptions::ConfigurationError: RuboCop exited unsuccessfully with status 2. Here is its output to check the stack trace or see if there was a misconfiguration:
    --except option: Lint/BlockAlignment has the wrong namespace - should be Layout
    --except option: Lint/EndAlignment has the wrong namespace - should be Layout
    --except option: Metrics/LineLength has the wrong namespace - should be Layout
    --except option: Style/BlockNesting has the wrong namespace - should be Metrics
    --except option: Style/ExtraSpacing has the wrong namespace - should be Layout
    --except option: Style/FileName has the wrong namespace - should be Naming
    --except option: Style/IndentationWidth has the wrong namespace - should be Layout
    --except option: Style/TrailingWhitespace has the wrong namespace - should be Layout
    --except option: Style/SpaceAroundOperators has the wrong namespace - should be Layout
    Unrecognized cop or department: Style/AlignParameters.
    Did you mean? Style/OptionalBooleanParameter

app/views/catalog/explorer.html.haml

  • 💣 💥 🔥 🚒 - Line 0 - Couldn't process the file for linting. HamlLint::Exceptions::ConfigurationError: RuboCop exited unsuccessfully with status 2. Here is its output to check the stack trace or see if there was a misconfiguration:
    --except option: Lint/BlockAlignment has the wrong namespace - should be Layout
    --except option: Lint/EndAlignment has the wrong namespace - should be Layout
    --except option: Metrics/LineLength has the wrong namespace - should be Layout
    --except option: Style/BlockNesting has the wrong namespace - should be Metrics
    --except option: Style/ExtraSpacing has the wrong namespace - should be Layout
    --except option: Style/FileName has the wrong namespace - should be Naming
    --except option: Style/IndentationWidth has the wrong namespace - should be Layout
    --except option: Style/TrailingWhitespace has the wrong namespace - should be Layout
    --except option: Style/SpaceAroundOperators has the wrong namespace - should be Layout
    Unrecognized cop or department: Style/AlignParameters.
    Did you mean? Style/OptionalBooleanParameter
  • 💣 💥 🔥 🚒 - Line 11 - Do not repeat id "#main_div" on the page
  • 💣 💥 🔥 🚒 - Line 4 - Do not repeat id "#main_div" on the page

app/views/layouts/_performance_async.html.haml

  • 💣 💥 🔥 🚒 - Line 0 - Couldn't process the file for linting. HamlLint::Exceptions::ConfigurationError: RuboCop exited unsuccessfully with status 2. Here is its output to check the stack trace or see if there was a misconfiguration:
    --except option: Lint/BlockAlignment has the wrong namespace - should be Layout
    --except option: Lint/EndAlignment has the wrong namespace - should be Layout
    --except option: Metrics/LineLength has the wrong namespace - should be Layout
    --except option: Style/BlockNesting has the wrong namespace - should be Metrics
    --except option: Style/ExtraSpacing has the wrong namespace - should be Layout
    --except option: Style/FileName has the wrong namespace - should be Naming
    --except option: Style/IndentationWidth has the wrong namespace - should be Layout
    --except option: Style/TrailingWhitespace has the wrong namespace - should be Layout
    --except option: Style/SpaceAroundOperators has the wrong namespace - should be Layout
    Unrecognized cop or department: Style/AlignParameters.
    Did you mean? Style/OptionalBooleanParameter

app/views/layouts/_tl_show_async.html.haml

  • 💣 💥 🔥 🚒 - Line 0 - Couldn't process the file for linting. HamlLint::Exceptions::ConfigurationError: RuboCop exited unsuccessfully with status 2. Here is its output to check the stack trace or see if there was a misconfiguration:
    --except option: Lint/BlockAlignment has the wrong namespace - should be Layout
    --except option: Lint/EndAlignment has the wrong namespace - should be Layout
    --except option: Metrics/LineLength has the wrong namespace - should be Layout
    --except option: Style/BlockNesting has the wrong namespace - should be Metrics
    --except option: Style/ExtraSpacing has the wrong namespace - should be Layout
    --except option: Style/FileName has the wrong namespace - should be Naming
    --except option: Style/IndentationWidth has the wrong namespace - should be Layout
    --except option: Style/TrailingWhitespace has the wrong namespace - should be Layout
    --except option: Style/SpaceAroundOperators has the wrong namespace - should be Layout
    Unrecognized cop or department: Style/AlignParameters.
    Did you mean? Style/OptionalBooleanParameter

app/views/ops/_diagnostics_utilization_tab.html.haml

  • 💣 💥 🔥 🚒 - Line 0 - Couldn't process the file for linting. HamlLint::Exceptions::ConfigurationError: RuboCop exited unsuccessfully with status 2. Here is its output to check the stack trace or see if there was a misconfiguration:
    --except option: Lint/BlockAlignment has the wrong namespace - should be Layout
    --except option: Lint/EndAlignment has the wrong namespace - should be Layout
    --except option: Metrics/LineLength has the wrong namespace - should be Layout
    --except option: Style/BlockNesting has the wrong namespace - should be Metrics
    --except option: Style/ExtraSpacing has the wrong namespace - should be Layout
    --except option: Style/FileName has the wrong namespace - should be Naming
    --except option: Style/IndentationWidth has the wrong namespace - should be Layout
    --except option: Style/TrailingWhitespace has the wrong namespace - should be Layout
    --except option: Style/SpaceAroundOperators has the wrong namespace - should be Layout
    Unrecognized cop or department: Style/AlignParameters.
    Did you mean? Style/OptionalBooleanParameter

app/views/ops/explorer.html.haml

  • 💣 💥 🔥 🚒 - Line 0 - Couldn't process the file for linting. HamlLint::Exceptions::ConfigurationError: RuboCop exited unsuccessfully with status 2. Here is its output to check the stack trace or see if there was a misconfiguration:
    --except option: Lint/BlockAlignment has the wrong namespace - should be Layout
    --except option: Lint/EndAlignment has the wrong namespace - should be Layout
    --except option: Metrics/LineLength has the wrong namespace - should be Layout
    --except option: Style/BlockNesting has the wrong namespace - should be Metrics
    --except option: Style/ExtraSpacing has the wrong namespace - should be Layout
    --except option: Style/FileName has the wrong namespace - should be Naming
    --except option: Style/IndentationWidth has the wrong namespace - should be Layout
    --except option: Style/TrailingWhitespace has the wrong namespace - should be Layout
    --except option: Style/SpaceAroundOperators has the wrong namespace - should be Layout
    Unrecognized cop or department: Style/AlignParameters.
    Did you mean? Style/OptionalBooleanParameter
  • ⚠️ - Line 12 - Files should not end with trailing empty lines

app/views/report/explorer.html.haml

  • 💣 💥 🔥 🚒 - Line 0 - Couldn't process the file for linting. HamlLint::Exceptions::ConfigurationError: RuboCop exited unsuccessfully with status 2. Here is its output to check the stack trace or see if there was a misconfiguration:
    --except option: Lint/BlockAlignment has the wrong namespace - should be Layout
    --except option: Lint/EndAlignment has the wrong namespace - should be Layout
    --except option: Metrics/LineLength has the wrong namespace - should be Layout
    --except option: Style/BlockNesting has the wrong namespace - should be Metrics
    --except option: Style/ExtraSpacing has the wrong namespace - should be Layout
    --except option: Style/FileName has the wrong namespace - should be Naming
    --except option: Style/IndentationWidth has the wrong namespace - should be Layout
    --except option: Style/TrailingWhitespace has the wrong namespace - should be Layout
    --except option: Style/SpaceAroundOperators has the wrong namespace - should be Layout
    Unrecognized cop or department: Style/AlignParameters.
    Did you mean? Style/OptionalBooleanParameter

app/views/storage/_storage_list.html.haml

  • 💣 💥 🔥 🚒 - Line 0 - Couldn't process the file for linting. HamlLint::Exceptions::ConfigurationError: RuboCop exited unsuccessfully with status 2. Here is its output to check the stack trace or see if there was a misconfiguration:
    --except option: Lint/BlockAlignment has the wrong namespace - should be Layout
    --except option: Lint/EndAlignment has the wrong namespace - should be Layout
    --except option: Metrics/LineLength has the wrong namespace - should be Layout
    --except option: Style/BlockNesting has the wrong namespace - should be Metrics
    --except option: Style/ExtraSpacing has the wrong namespace - should be Layout
    --except option: Style/FileName has the wrong namespace - should be Naming
    --except option: Style/IndentationWidth has the wrong namespace - should be Layout
    --except option: Style/TrailingWhitespace has the wrong namespace - should be Layout
    --except option: Style/SpaceAroundOperators has the wrong namespace - should be Layout
    Unrecognized cop or department: Style/AlignParameters.
    Did you mean? Style/OptionalBooleanParameter

app/views/utilization/index.html.haml

  • 💣 💥 🔥 🚒 - Line 0 - Couldn't process the file for linting. HamlLint::Exceptions::ConfigurationError: RuboCop exited unsuccessfully with status 2. Here is its output to check the stack trace or see if there was a misconfiguration:
    --except option: Lint/BlockAlignment has the wrong namespace - should be Layout
    --except option: Lint/EndAlignment has the wrong namespace - should be Layout
    --except option: Metrics/LineLength has the wrong namespace - should be Layout
    --except option: Style/BlockNesting has the wrong namespace - should be Metrics
    --except option: Style/ExtraSpacing has the wrong namespace - should be Layout
    --except option: Style/FileName has the wrong namespace - should be Naming
    --except option: Style/IndentationWidth has the wrong namespace - should be Layout
    --except option: Style/TrailingWhitespace has the wrong namespace - should be Layout
    --except option: Style/SpaceAroundOperators has the wrong namespace - should be Layout
    Unrecognized cop or department: Style/AlignParameters.
    Did you mean? Style/OptionalBooleanParameter

app/views/vm_infra/explorer.html.haml

  • 💣 💥 🔥 🚒 - Line 0 - Couldn't process the file for linting. HamlLint::Exceptions::ConfigurationError: RuboCop exited unsuccessfully with status 2. Here is its output to check the stack trace or see if there was a misconfiguration:
    --except option: Lint/BlockAlignment has the wrong namespace - should be Layout
    --except option: Lint/EndAlignment has the wrong namespace - should be Layout
    --except option: Metrics/LineLength has the wrong namespace - should be Layout
    --except option: Style/BlockNesting has the wrong namespace - should be Metrics
    --except option: Style/ExtraSpacing has the wrong namespace - should be Layout
    --except option: Style/FileName has the wrong namespace - should be Naming
    --except option: Style/IndentationWidth has the wrong namespace - should be Layout
    --except option: Style/TrailingWhitespace has the wrong namespace - should be Layout
    --except option: Style/SpaceAroundOperators has the wrong namespace - should be Layout
    Unrecognized cop or department: Style/AlignParameters.
    Did you mean? Style/OptionalBooleanParameter
  • 💣 💥 🔥 🚒 - Line 16 - Do not repeat id "#main_div" on the page
  • 💣 💥 🔥 🚒 - Line 23 - Do not repeat id "#main_div" on the page
  • 💣 💥 🔥 🚒 - Line 8 - Do not repeat id "#main_div" on the page

app/views/vm_or_template/explorer.html.haml

  • 💣 💥 🔥 🚒 - Line 0 - Couldn't process the file for linting. HamlLint::Exceptions::ConfigurationError: RuboCop exited unsuccessfully with status 2. Here is its output to check the stack trace or see if there was a misconfiguration:
    --except option: Lint/BlockAlignment has the wrong namespace - should be Layout
    --except option: Lint/EndAlignment has the wrong namespace - should be Layout
    --except option: Metrics/LineLength has the wrong namespace - should be Layout
    --except option: Style/BlockNesting has the wrong namespace - should be Metrics
    --except option: Style/ExtraSpacing has the wrong namespace - should be Layout
    --except option: Style/FileName has the wrong namespace - should be Naming
    --except option: Style/IndentationWidth has the wrong namespace - should be Layout
    --except option: Style/TrailingWhitespace has the wrong namespace - should be Layout
    --except option: Style/SpaceAroundOperators has the wrong namespace - should be Layout
    Unrecognized cop or department: Style/AlignParameters.
    Did you mean? Style/OptionalBooleanParameter
  • 💣 💥 🔥 🚒 - Line 16 - Do not repeat id "#main_div" on the page
  • 💣 💥 🔥 🚒 - Line 23 - Do not repeat id "#main_div" on the page
  • 💣 💥 🔥 🚒 - Line 8 - Do not repeat id "#main_div" on the page

GilbertCherrie
GilbertCherrie approved these changes May 22, 2024
View reviewed changes
app/views/ops/explorer.html.haml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before it was: miqReportAfterOnload so it looks good now. New code is using the same function as the old code now.

@Fryguy Fryguy merged commit 7d5b890 into ManageIQ:morphy May 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GilbertCherrie GilbertCherrie GilbertCherrie approved these changes

@Fryguy Fryguy Awaiting requested review from Fryguy

Assignees

@Fryguy Fryguy

@GilbertCherrie GilbertCherrie

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jeffibm @miq-bot @Fryguy @GilbertCherrie