Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Simulation form conversion #9111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Simulation form conversion #9111

wants to merge 1 commit into from

Conversation

Ronat58
Copy link
Contributor

@Ronat58 Ronat58 commented Mar 11, 2024

@miq-bot add-reviewer @Fryguy
@miq-bot add-reviewer @jeffibm
@miq-bot add-label enhancement
@miq-bot assign @jeffibm

  1. React form conversion for simulation page
    Path: Automation/Automate/Simulation

  2. Pending: Need to make the "Attribute/Value pairs" in horizontal

Before
Screenshot 2024-03-05 at 6 04 11 PM

After
Screenshot 2024-03-11 at 9 22 37 AM
Screenshot 2024-03-11 at 9 22 59 AM

@Ronat58 Ronat58 requested a review from a team as a code owner March 11, 2024 06:00
@miq-bot miq-bot requested review from Fryguy and jeffibm March 11, 2024 06:01
@miq-bot
Copy link
Member

miq-bot commented Mar 11, 2024

Checked commit Ronat58@ee5cbbf with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
2 files checked, 13 offenses detected

app/views/layouts/_ae_resolve_options.html.haml

  • ⚠️ - Line 10 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.
  • ⚠️ - Line 11 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.
  • ⚠️ - Line 12 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.
  • ⚠️ - Line 13 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.
  • ⚠️ - Line 14 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.
  • ⚠️ - Line 15 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.
  • ⚠️ - Line 16 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.
  • ⚠️ - Line 16 - Line is too long. [92/80]
  • ⚠️ - Line 17 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.
  • ⚠️ - Line 18 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.
  • ⚠️ - Line 7 - Avoid using instance variables in partials views
  • ⚠️ - Line 8 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.
  • ⚠️ - Line 9 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.

@jeffibm
Copy link
Member

jeffibm commented Mar 13, 2024

Hey @Ronat58 , I am changing this to WIP since it's not complete.
Also, could you please update the TODO List when you find time?
Thanks.

@jeffibm jeffibm changed the title Simulation form conversion [WIP] Simulation form conversion Mar 13, 2024
@miq-bot miq-bot added the wip label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryguy Fryguy Awaiting requested review from Fryguy

@jeffibm jeffibm Awaiting requested review from jeffibm

Assignees

@jeffibm jeffibm

Labels
enhancement wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ronat58 @miq-bot @jeffibm