Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Embedded method tree conversion #9052

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeffibm
Copy link
Member

@jeffibm jeffibm commented Jan 25, 2024

Note: This is an experimental work. Also trying a different approach to avoid the tree structure in another PR.

  • Create a AeInlineMethods component to render the list and add method button
  • Create a modal to display the tree component.
  • Create a MiqTree component
  • Create a MiqTreeNode component to display a row in tree
  • Create a MiqtreeParentNode to render a parent item
  • Create a MiqTreeChildNode to render the child items
  • Call the MiqTreeNode component in MiqTreeChildNode as a recursive function to reuse the code
  • If one item is selected, only then enable the modals ok button
  • Pass the selected item to the AeInlineMethods to add them to the array
  • List the items in the AeInlineMethods
  • Add a loader near to the selected item
  • Style the list
  • Make it reusable across MIQ
  • Multiselect feature
  • checkboxes

Before

  • This dialog and its contents were used in angular.
image

After

  • Custom made tree component in React.
  • This is not using the old react-wooden-tree package.

image

Upadted on Jan 29, 2023 - #9052 (comment)

@jeffibm jeffibm requested a review from a team as a code owner January 25, 2024 14:50
@miq-bot miq-bot added the wip label Jan 25, 2024
@jeffibm
Copy link
Member Author

jeffibm commented Jan 29, 2024

Screen.Recording.2024-01-29.at.6.51.49.PM.mov

@jeffibm jeffibm force-pushed the embedded-method-tree-conversion branch from 635ab05 to 444ef60 Compare January 30, 2024 09:16
@miq-bot
Copy link
Member

miq-bot commented Jan 30, 2024

Checked commit jeffbonson@444ef60 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 👍

@miq-bot miq-bot added the stale label May 6, 2024
@miq-bot
Copy link
Member

miq-bot commented May 6, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants