[WIP] Introduce the VM description editing page

[jeffibm]

Edit this VM Description

Related PRS -

1. Add VM set_description action manageiq-api#1120
2. [WIP] Introduce the VM description editing page manageiq#22774

Issue - ManageIQ/manageiq#21561

[agrare]

@jeffibm is there a supports feature check here?

[jeffibm]

@jeffibm is there a supports feature check here?

Hey @agrare , I replicated the same process for the edit page. Did not see a support feature check for that.

[jeffibm]

Hey @kbrock , I was able to update the description with the old API. Is this alright?

Screen.Recording.2023-11-06.at.10.45.09.AM.mov

[kbrock]

@jeffibm I see an example case using the api to edit a description: https://github.com/ManageIQ/manageiq-api/blob/master/spec/requests/vms_spec.rb#L1590

Is there a reason to not use this api and introduce on in ui-classic?

update:

url: `api/vms/#{record.id}`
payload: {"action"=>"set_description", "resource"=>{"new_description"=>"test"}}

[agrare]

I replicated the same process for the edit page. Did not see a support feature check for that.

I don't believe that means that we don't need one though. It looks like the previous edit page only changed attributes that live in our database, which means every providers' vms would support it. Setting the description on the underlying provider object is not the same.

[jeffibm]

TODO: remove this

[kbrock]

class Vm
  supports :set_description
end

This works for vmware vms, templates, and ibm_power_hmc vms (where host_hmc_managed)

The privileges for this is the basic vm_edit, with a full path of all_vm_rules/vm_admin/vm_edit

[kbrock]

If we keep the feature flag as vm_edit instead of vm_edit_description, I'm not sure if we need to do something special with privileges.

(which is different from the :set_description ems supports flag)

[miq-bot]

Checked commit jeffbonson@c987fd6 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
4 files checked, 16 offenses detected

app/controllers/application_controller/explorer.rb

• ❗ - Line 49, Col 52 - Layout/SpaceAroundOperators - Operator => should be surrounded by a single space.
• ❗ - Line 49, Col 78 - Layout/SpaceAroundOperators - Operator => should be surrounded by a single space.

app/controllers/vm_common.rb

• ❗ - Line 610, Col 3 - Style/Alias - Use alias instead of alias_method in a module body.

app/helpers/application_helper/toolbar/x_vm_center.rb

• ❗ - Line 46, Col 11 - Layout/ArrayAlignment - Align the elements of an array literal if they span more than one line.
• ❗ - Line 51, Col 55 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/views/vm_common/_form.html.haml

• ⚠️ - Line 3 - Avoid using instance variables in partials views
• ⚠️ - Line 3 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 3 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 3 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 3 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 3 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 3 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 3 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 3 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 3 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 3 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.

[kbrock]

@jeffibm did you say that the API was not working for you if the user had vm_edit privileges? Or maybe it was not displaying the entry in the dropdown?

[jeffibm]

@jeffibm did you say that the API was not working for you if the user had vm_edit privileges? Or maybe it was not displaying the entry in the dropdown?

If we try to use the same vm_edit in the menu section, it would complain about duplicate id being used in the actual "Edit this VM" button. So that made me create a new vm_edit_description.

[kbrock]

@jeffibm did you say that the API was not working for you if the user had vm_edit privileges? Or maybe it was not displaying the entry in the dropdown?

If we try to use the same vm_edit in the menu section, it would complain about duplicate id being used in the actual "Edit this VM" button. So that made me create a new vm_edit_description.

Can we have 2 menu items that depend upon the same privileges. vm_edit is privileges, not a menu selection.

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).