-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed dashboard cypress tests #8892
base: master
Are you sure you want to change the base?
Fixed dashboard cypress tests #8892
Conversation
Checked commit GilbertCherrie@982cb9c with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - will wait until we get in the simulate_queue_worker change. (Though it is curious that the UI changes at all whether workers are running or not - we should investigate that separately)
Hey @Fryguy , and @GilbertCherrie , can we merge this? |
@jeffibm No we can't merge this yet as it relies on simulate_queue_worker to be enabled in the cypress environment or else these tests will fail. |
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
Once simulate_queue_worker is enabled for cypress tests the dashboard widgets get more buttons which breaks the current tests. @Fryguy Once we enable simulate_queue_worker in the github actions environment then we should merge this pr to fix the dashboard tests.
The new buttons added to the widget "Full Screen" and "Print or export to PDF" can't be tested as far as I am aware. This is because both of these buttons open a page in a new tab and Cypress does not support testing in other tabs. There is ways to override a link from opening in a new tab when using the html element but since we are using buttons that open a new tab we can't override this behaviour.