[WIP] Allow more specific restriction types for roles

[jaywcarman]

Related to:

• [WIP] Allow more specific restriction types for roles manageiq#22650
• [WIP] Allow more specific restriction types for roles manageiq-schema#700

Follow up to #8833, which introduced separate restrictions for Catalog Items.

This changes further splits the role restriction settings to include the following types:

• Catalog Items
• Key Pairs
• Orchestration Stacks
• Services
• VMs and Templates

[miq-bot]

Checked commit jaywcarman@595bd50 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
3 files checked, 5 offenses detected

app/controllers/ops_controller/ops_rbac.rb

• ❗ - Line 1398, Col 22 - Style/StringConcatenation - Prefer string interpolation to string concatenation.

app/views/ops/_rbac_role_details.html.haml

• ⚠️ - Line 37 - Avoid using instance variables in partials views
• ⚠️ - Line 49 - Avoid using instance variables in partials views
• ⚠️ - Line 61 - Avoid using instance variables in partials views
• ⚠️ - Line 73 - Avoid using instance variables in partials views

[jaywcarman]

Before this change, viewing a role:

Before this change, editing a role:

With this change, viewing a role:

With this change, editing a role:

[jaywcarman]

While it is functional, I don't really like the new role view. The phrase "Access Restriction for ..." is repeated five times. This also causes each access restriction label to wrap onto two lines. Yuck 🥴 !

I'm looking into grouping the restriction settings to improve. Suggestions are welcome 😄

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).