Add direct redux npm dependency, redux 4.0.0 breaks #3790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Redux 4 is here!](https://github.com/reactjs/redux/releases) and [yarn is broken](https://gist.github.com/bdunne/c58ae9f3c26e6647f29392c6cfba7f2b) :(. Turns out we only depend on redux indirectly, which means the redux 4.0.0 release broke the webpack build.. ERROR in /home/bdunne/.gem/ruby/2.4.3/bundler/gems/manageiq-ui-classic-8303c278b9c0/node_modules/redux/index.d.ts (19,27): error TS1005: ',' expected. (and quite a bit more) Adding that direct dependency. Also removed @types/redux, since it has been [deprecated](https://www.npmjs.com/package/@types/redux).
bdunne
approved these changes
Apr 18, 2018
|
(Redux was introduced in #2504, so nothing but master is affected.) |
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/78d7bf292c539d69f0fa1eb7dd4d09dd0831b129 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
(Turns out, #3781 also fixes the build problem, but better be explicit than to randomly upgrade to a new major version.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redux 4 is here! and yarn is broken :(.
Turns out we only depend on redux indirectly, which means the redux 4.0.0 release broke the webpack build..
Adding that direct dependency.
Also removed
@types/redux, since it has been deprecated.Cc @bdunne