Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReferenceError: jasmine is not defined #3146

Merged
merged 1 commit into from Jan 2, 2018
Merged

Fix ReferenceError: jasmine is not defined #3146

merged 1 commit into from Jan 2, 2018

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Jan 2, 2018

introduced in #2504

causes

Uncaught ReferenceError: jasmine is not defined
    at eval (index.ts?37df:8)
    at Object.<anonymous> (miq-redux-common.js:183)
    at __webpack_require__ (miq-redux-common.js:20)
    at eval (miq-redux-common.js?4cb0:1)
    at Object.<anonymous> (miq-redux-common.js:171)
    at __webpack_require__ (miq-redux-common.js:20)
    at miq-redux-common.js:63
    at miq-redux-common.js:66

in the browser console.

Cc @vojtechszocs

introduced in #2504

causes

```
Uncaught ReferenceError: jasmine is not defined
    at eval (index.ts?37df:8)
    at Object.<anonymous> (miq-redux-common.js:183)
    at __webpack_require__ (miq-redux-common.js:20)
    at eval (miq-redux-common.js?4cb0:1)
    at Object.<anonymous> (miq-redux-common.js:171)
    at __webpack_require__ (miq-redux-common.js:20)
    at miq-redux-common.js:63
    at miq-redux-common.js:66
```

in the browser console.
@himdel
Copy link
Contributor Author

himdel commented Jan 2, 2018

(window['jasmine'] instead of window.jasmine because Typescript :))

@mzazrivec mzazrivec self-assigned this Jan 2, 2018
@mzazrivec mzazrivec added the test label Jan 2, 2018
@mzazrivec mzazrivec added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 2, 2018
@mzazrivec mzazrivec merged commit d809933 into ManageIQ:master Jan 2, 2018
@himdel himdel deleted the jasmine branch January 2, 2018 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants