Remove creation of manageiq.liveness-check topic #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nasark
changed the title
|
Need a cr migration to remove the |
nasark
changed the title
nasark
force-pushed
the
remove_health_check_topic
branch
from
46749fa
to
23007fd
Compare
|
@bdunne Added the CR migration, please review |
nasark
force-pushed
the
remove_health_check_topic
branch
from
23007fd
to
73b87c5
Compare
nasark
commented
May 23, 2024
| @@ -59,6 +60,19 @@ func FindKafka(client client.Client, scheme *runtime.Scheme, namespace string, n | |||
| return kafka | |||
| } | |||
|
|
|||
| func FindKafkaTopic(client client.Client, scheme *runtime.Scheme, namespace string, name string, group string) *unstructured.Unstructured { | |||
There was a problem hiding this comment.
Added group as a parameter so that this function can be reused downstream
|
Checked commits nasark/manageiq-pods@905ebb3~...73b87c5 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
|
Backported to |
Fryguy
pushed a commit
that referenced
this pull request
May 24, 2024
Remove creation of manageiq.liveness-check topic (cherry picked from commit 3ee8237)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer use a push/pop approach as health check for kafka via the orchestrator and so this topic no longer needs to be created
Ref: ManageIQ/manageiq#23020
@miq-bot assign @bdunne
@miq-bot add_reviewers @bdunne, @Fryguy
@miq-bot add_labels bug, radjabov/yes?