Fix off-by-one error in Beast-format input. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would mangle messages if the first byte of a message ended up as the last byte returned by a read() call - it would read beyond the end of the buffer, decide the message was damaged, and then run off into the message data looking for a new delimiter. Sometimes that would work (only dropping one message), but sometimes it would run into data that happened to look like a message start but actually wasn't, and then try to interpret that, leading to completely bogus message data being read. (cherry picked from commit e7d7fd5)
|
just inserted the code in to my fork it has this and plane count and plane count in title and signal and settings page and lots more including almost all pull request here demo at http://bitropy.net:8080 |
devbender
pushed a commit
to devbender/dump1090
that referenced
this pull request
Dec 1, 2020
Add commented-out HTTPS configuration section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would mangle messages if the first byte of a message ended up
as the last byte returned by a read() call - it would read beyond
the end of the buffer, decide the message was damaged, and then run
off into the message data looking for a new delimiter. Sometimes
that would work (only dropping one message), but sometimes it would
run into data that happened to look like a message start but
actually wasn't, and then try to interpret that, leading to completely
bogus message data being read.
(cherry picked from commit e7d7fd5)