Nickcolour gui #115
Open
Nickcolour gui #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funnyboy-roks
commented
Aug 12, 2023
Comment on lines
+63
to
+78
| BLACK = generateItem("Black", NamedTextColor.BLACK, CustomHead.BLACK.asItemStack() ); | ||
| DARK_BLUE = generateItem("Dark Blue", NamedTextColor.DARK_BLUE, CustomHead.DARK_BLUE.asItemStack() ); | ||
| DARK_GREEN = generateItem("Dark Green", NamedTextColor.DARK_GREEN, CustomHead.DARK_GREEN.asItemStack() ); | ||
| DARK_AQUA = generateItem("Dark Aqua", NamedTextColor.DARK_AQUA, CustomHead.DARK_AQUA.asItemStack() ); | ||
| DARK_RED = generateItem("Dark Red", NamedTextColor.DARK_RED, CustomHead.DARK_RED.asItemStack() ); | ||
| DARK_PURPLE = generateItem("Dark Purple", NamedTextColor.DARK_PURPLE, CustomHead.DARK_PURPLE.asItemStack() ); | ||
| GOLD = generateItem("Gold", NamedTextColor.GOLD, CustomHead.GOLD.asItemStack() ); | ||
| GRAY = generateItem("Gray", NamedTextColor.GRAY, CustomHead.GRAY.asItemStack() ); | ||
| DARK_GRAY = generateItem("Dark Gray", NamedTextColor.DARK_GRAY, CustomHead.DARK_GRAY.asItemStack() ); | ||
| BLUE = generateItem("Blue", NamedTextColor.BLUE, CustomHead.BLUE.asItemStack() ); | ||
| GREEN = generateItem("Green", NamedTextColor.GREEN, CustomHead.GREEN.asItemStack() ); | ||
| AQUA = generateItem("Aqua", NamedTextColor.AQUA, CustomHead.AQUA.asItemStack() ); | ||
| RED = generateItem("Red", NamedTextColor.RED, CustomHead.RED.asItemStack() ); | ||
| LIGHT_PURPLE = generateItem("Light Purple", NamedTextColor.LIGHT_PURPLE, CustomHead.LIGHT_PURPLE.asItemStack() ); | ||
| YELLOW = generateItem("Yellow", NamedTextColor.YELLOW, CustomHead.YELLOW.asItemStack() ); | ||
| WHITE = generateItem("White", NamedTextColor.WHITE, CustomHead.WHITE.asItemStack() ); |
There was a problem hiding this comment.
While every button and label uses admin-set messages, I'm not sure that it should be done for these, as they're the vanilla names. If we were to add customisable names for these, I'm not sure how that should be implemented in a way that works nicely since having
Args0 GUI_NICK_COLOR_BLACK = () -> ...for each colour would be a lot of extra clutter, especially if they aren't changed by the server admin.
Alternatively, we could change them to be black, dark_blue, etc. like the vanilla names are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a GUI for
/nickcolorwith no arguments.This should resolve #50.
This PR adds a GuiManager class that manages GUIs (shocking, I know). It is accessible through
HexNicks.guis()and handles all click events, and GUIs for the plugin. I tried to implement it in such a way that one can add GUIs in the future with ease.