Fixed stacked cancel task that create huge lag. #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix when it stack cancel task several hundreds if times and create a crash of the server.
|
I have not however check your two lib's is updated, you seams to use FreeMinecraftModels 1.1.3-SNAPSHOT I use the local 1.7.4-SNAPSHOT. I can't access the 1.1.3-SNAPSHOT version at all. |
|
I've implemented a fix for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if it a reason you attempt to cancel already stopped task. It seams to create endless stacked tasks that the server try to stop same taskid.
So I simply set it back to null and the problem seams to be gone and not notes negative effects.
With my fix on latest version on GitHub: https://spark.lucko.me/paGLyk157A
Without the fix: https://spark.lucko.me/BVUG0B9Vca it take around 7/8% of a tick.
I also get this problem whit the latest on spigot that says it is still version 8.7.6: https://spark.lucko.me/TlRe4elUuu You see the issue below, did not see this effect on latest version on GitHub with my small fix added yet.
