Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a notifications helper class #971

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xaoseric
Copy link

@xaoseric xaoseric commented Sep 1, 2019

This adds a notifications helper class, should help with implementing issue #951

Copy link
Member

@mstarke mstarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR but this is currently not mergeable for 0.7.x since the UserNotification framework requires 10.14 and the deploy target for MacPass ist still 10.10. This will be raised with 0.8 to 10.12 or even higher but the 0.7.x branch should stay compatible with 10.10. which requires to stick with the deprecated NSUserNotification. Another note - I'm hesitant to introduce .swift code since it requires to bundle the swift runtime AFAIK and I also do not have no plans to fully convert MacPass to swift any time soon. This might sound foolish but for now I'm more productive with Obj-C and keeping the code base manageable for me is of high value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants