Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #910 Search results just disappear when switching to other app and back #947

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed #910 Search results just disappear when switching to other app and back #947

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion MacPass/MPOutlineViewController.m
View file
Open in desktop
Expand Up @@ -221,7 +221,9 @@ - (void)_didBecomeFirstResponder:(NSNotification *)notification {
return; // Nothing we need to worry about
}
MPDocument *document = self.windowController.document;
document.selectedGroups = self.currentTargetGroups;
if (document.selectedGroups != self.currentTargetGroups) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed the issue of an unexpected exit of search but raises another. When a user clicks inside the outline view and selects the currently selected group this wont show up in the inspector. Instead another group needs to be selected and the the old on should be re-selected. It might be usefull to go a special route just if search is active

document.selectedGroups = self.currentTargetGroups;
}
}

- (void)_outlineDidScroll:(NSNotification *)notification {
Expand Down