Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #1104 (Rendering pane flashing) #1288

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Jan 12, 2022

  1. Fixes issue MacDownApp#1104 (Rendering pane flashing)

    For issue MacDownApp#747, a change was introduced that uses private API to disable
    caching on the preview pane's web view. This was ostensibly to make it
    so that if images referenced in the markdown document are changed on
    disk, their changes are reflected in the preview pane.
    
    Unfortunately, perhaps due to some underlying changes to WebKit/WebView,
    disabling caching will also disable caching for all sorts of other
    things like stylesheets and the base html document loaded from disk.
    This results in a momentary flash of empty content if one is typing
    quickly.
    
    Reverting the changes for MacDownApp#747 resolves the flashing issue, but does
    regress the issue regarding images being persistently cached.
    
    However, the flashing issue appears to be bothering more people than the
    image issue, so I believe it would be appropriate to temporarily regress
    the image caching bug to resolve the flashing bug. Supposedly, a plan
    exists to migrate to WKWebView, which would hopefully resolve both of
    these issues simultaneously.
    buzzert committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    23042a4 View commit details
    Browse the repository at this point in the history