Merge pull request #1679 from MTG/bw-fix-embed-code

fix property access in HTMLElement dataset
MTG · Mar 23, 2023 · e5d62cb · e5d62cb
2 parents d3861b8 + ddacedf
commit e5d62cb
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/freesound/static/bw-frontend/src/pages/sound.js b/freesound/static/bw-frontend/src/pages/sound.js
@@ -52,18 +52,18 @@ toggleShareLinkElement.addEventListener('click',  toggleShareLink);
 
 
 const generateEmbedCode = (size) => {
-    var sizes = embedCodeElement.dataset['size-' + size].split(',');
-    var urlTemplate = embedCodeElement.dataset['iframe-url-template'];
+    var sizes = embedCodeElement.dataset['size' + size].split(',');
+    var urlTemplate = embedCodeElement.dataset.iframeUrlTemplate;
     var embedText = '<iframe frameborder="0" scrolling="no" src="' + urlTemplate + '" width="WIDTH" height="HEIGHT"></iframe>';
     embedText = embedText.replace('SIZE', size);
     embedText = embedText.replace('WIDTH', sizes[0]);
     embedText = embedText.replace('HEIGHT', sizes[1]);
     embedCodeElement.value = embedText;
 }
 
-smallEmbedImageElement.addEventListener('click',  () => generateEmbedCode('small'));
-mediumEmbedImageElement.addEventListener('click', () => generateEmbedCode('medium'));
-largeEmbedImageElement.addEventListener('click', () => generateEmbedCode('large'));
+smallEmbedImageElement.addEventListener('click',  () => generateEmbedCode('Small'));
+mediumEmbedImageElement.addEventListener('click', () => generateEmbedCode('Medium'));
+largeEmbedImageElement.addEventListener('click', () => generateEmbedCode('Large'));
 
 embedLinksElement.style.display = "none"
 shareLinkElement.style.display = "none"
@@ -109,4 +109,3 @@ if (similarSoundsButtons.length > 0){
         openSimilarSoundsModal(similarSoundsButtons[0].dataset.modalContentUrl, similarSoundsModalActivationParam);
     }
 }
-