Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create docker-image.yml #24

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Create docker-image.yml #24

wants to merge 20 commits into from

Conversation

phiphi0815
Copy link
Collaborator

Builds and pushes new docker image when pushed to master or pull request.

Builds and pushes new docker image when pushed to master or pull request.
@armaneshaghi
Copy link
Contributor

@phiphi0815 Please see the error in docker build when adding the group.

@jstutters
Copy link
Contributor

@phiphi0815 might want to try adding some caching to this or add an issue to work on that later.

Copy link
Contributor

@armaneshaghi armaneshaghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding a clear container build

@armaneshaghi
Copy link
Contributor

Happy to merge when all checks (under checks tab) pass with no error

@phiphi0815
Copy link
Collaborator Author

Github hosted runners run out of space due to large docker image of mindglide when automatically updating dockerhub with github actions.

Solution:
Currently I will manually push updated docker images to dockerhub. In the future we can think about self-hosted runners.

@armaneshaghi
Copy link
Contributor

@jstutters is it worth setting up a Docker as a self hosted runner within the Unit? The config looks relatively straightforward

@armaneshaghi
Copy link
Contributor

spoke @jstutters and @phiphi0815

  • @jstutters to push a branch to clean up docker to be less than 14GB
  • @phiphi0815 to retry with a pruned image from Jon's work

@phiphi0815
Copy link
Collaborator Author

I have removed the old models (to prune the image and save space) on the branch remove_old_models.

Branch: remove_old_models

The Github hosted runner is still running out of space after removing the old models. (Docker image size previously: 18.6GB; currently: 17.2GB

@jstutters
Copy link
Contributor

@phiphi0815 does it improve things if you merge master into remove_old_models? Probably also need to edit

RUN git checkout c501cbef2c291b4920b9a8ad3e4a67f334f79f30
so it uses a commit that has the single model file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants