Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CartesianConvolution #98

Merged
merged 2 commits into from
May 24, 2023
Merged

CartesianConvolution #98

merged 2 commits into from
May 24, 2023

Conversation

stigrj
Copy link
Contributor

@stigrj stigrj commented May 24, 2023

  • Update to new MRCPP-v1.5
  • Add interface to gauge-like operators (e.g. xy/r^3)

@stigrj stigrj requested a review from robertodr May 24, 2023 17:23
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch coverage: 92.30% and project coverage change: +0.21 🎉

Comparison is base (1bfb61c) 83.64% compared to head (9e66def) 83.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   83.64%   83.85%   +0.21%     
==========================================
  Files          22       22              
  Lines         868      892      +24     
==========================================
+ Hits          726      748      +22     
- Misses        142      144       +2     
Impacted Files Coverage Δ
src/vampyr/operators/derivatives.h 92.30% <ø> (-0.55%) ⬇️
src/vampyr/operators/convolutions.h 93.58% <92.30%> (-0.75%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stigrj stigrj requested a review from bjorgve May 24, 2023 18:27
Copy link
Contributor

@robertodr robertodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The repo2docker build failure is unrelated, though I'm not quite sure how to fix it.

@stigrj stigrj merged commit 7094a3f into MRChemSoft:master May 24, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants