Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time evolution binding #113

Merged
merged 15 commits into from Nov 24, 2023
Merged

Time evolution binding #113

merged 15 commits into from Nov 24, 2023

Conversation

edinvay
Copy link
Contributor

@edinvay edinvay commented Oct 17, 2023

The binding for the time evolution operator is ready for use in 1d.
Also added Filter matrices.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (413283f) 63.19% compared to head (c6a7f65) 63.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #113   +/-   ##
=======================================
  Coverage   63.19%   63.19%           
=======================================
  Files           4        4           
  Lines         269      269           
=======================================
  Hits          170      170           
  Misses         99       99           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edinvay edinvay marked this pull request as draft October 31, 2023 12:11
@edinvay edinvay marked this pull request as ready for review November 22, 2023 15:10
Copy link
Member

@bjorgve bjorgve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Add a test and it can be approved.

Extra points if you add documentation :)

cmake/custom/fetch_mrcpp.cmake Outdated Show resolved Hide resolved
src/vampyr/treebuilders/applys.h Outdated Show resolved Hide resolved
@edinvay edinvay marked this pull request as draft November 23, 2023 08:17
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@edinvay edinvay marked this pull request as ready for review November 24, 2023 14:34
Copy link
Member

@bjorgve bjorgve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjorgve bjorgve merged commit 2c52b30 into MRChemSoft:master Nov 24, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants