Moved dunders to impl__ implementation in trees #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #104 +/- ##
=======================================
Coverage 90.90% 90.90%
=======================================
Files 3 3
Lines 187 187
=======================================
Hits 170 170
Misses 17 17 ☔ View full report in Codecov by Sentry. |
robertodr
reviewed
Jul 17, 2023
robertodr
reviewed
Jul 17, 2023
robertodr
reviewed
Jul 17, 2023
|
I think the Footnotes
|
|
Updated. I was sure I had tested, and concluded overload cast was needed. Apparently not. |
robertodr
approved these changes
Aug 26, 2023
stigrj
added a commit
that referenced
this pull request
Dec 7, 2023
* Update readme * Try to fix binder.yml workflow * Do not run binder.yml on PRs * Add quadrature to MWNode and FunctionTree * Update src/vampyr/trees/trees.h * Throw exceiption in 1D and 2D f_tree quadrature requests. As suggested by Roberto. Thanks * __add__ and __iadd__ * Update pybind so it works with newer python versions (#103) * Fix RTD builds (#108) * Moved dunders to impl__ implementation in trees (#104) Co-authored-by: Roberto Di Remigio Eikås <roberto@totaltrash.xyz> * Work on documentation * Add hydrogen atom example * Add helium atom * Avoid killed kernel with badly defined analytic functions * update convolution operator and add comment to error catch * Add Beryllium atom notebook * Update notebooks * Update link to current mrcpp master * Run clang-format * Update MRCPP version to fetch * Add matplotlib, safeguard in plotter.py * Run black+isort on Python files * better solvent notebook (#107) Co-authored-by: Roberto Di Remigio Eikås <roberto@totaltrash.xyz> * Add authorship and instruction cells above executable cells (#110) * Remove repetition from `index.rst` (#112) * linked vampyr to the timeevol branch of evgeniy's fork * added _skbuild/ to .gitignore * added complex apply * added time evolution operator in 1d * minor changes to convolutions.h * Time evolution operator can now be imported * added filter class to get filter matrices U, H0, and so on * linked vampyr back to the master mrcpp branch * added a time evolution test * small changes proposed by a reviewer * def test_time_evolution(): * documentation * docs * docs * removed some stuff from notebook messing with other cells * Preparing v1.0rc1 --------- Co-authored-by: Magnar Bjorgve <magnbjor@gmail.com> Co-authored-by: Roberto Di Remigio Eikås <robertodr@users.noreply.github.com> Co-authored-by: Roberto Di Remigio Eikås <roberto@totaltrash.xyz> Co-authored-by: Gabriel <gabriel.a.gerez.s@uit.no> Co-authored-by: edinvay <evgeni36@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First take on moving lambdas away from dunders.
I also found that I could use overload_cast and avoid dunders like these:
Is this okey @robertodr ?
Do you think all lambdas should be reimplemented like this?