Improve render windows utility widgets #277
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dow. QmitkRenderWindowWidget offered a method to add a utility widget at the top of a render window only. But applications based on MITK want to add widgets also on bottom, left and right. - Extended AddUtilityWidget() to add a widget at all sides of a render window. - The interface is kept compatible.
kislinsk
requested changes
Nov 17, 2023
Co-authored-by: Stefan Dinkelacker <kislinsk@users.noreply.github.com>
kislinsk
approved these changes
Nov 17, 2023
|
Thanks for the contribution. We did a quick test and were able to show utility widgets as expected on the top (no regression) and bottom. On the left and right, though, widgets do not show up. Did you test it yourself with left or right and did it work for you? |
|
Hi.
Yes, I tested it with widgets at all sides and it worked, and the default position used in our application is at the right side, and this works fine.
Of cause, I tested it with the count() as index instead of -1, but this seems improbable as reason for this difference.
Best Regards
Trudbert
…________________________________
Von: Stefan Dinkelacker ***@***.***>
Gesendet: Freitag, 17. November 2023 11:26
An: MITK/MITK ***@***.***>
Cc: Schwoerer, Trudbert ***@***.***>; Author ***@***.***>
Betreff: Re: [MITK/MITK] Improve render windows utility widgets (PR #277)
Sie erhalten nicht oft eine E-Mail von ***@***.*** Erfahren Sie, warum dies wichtig ist<https://aka.ms/LearnAboutSenderIdentification>
EXTERNAL EMAIL
Thanks for the contribution. We did a quick test and were able to show utility widgets as expected on the top (no regression) and bottom. On the left and right, though, widgets do not show up. Did you test it yourself with left or right and did it work for you?
—
Reply to this email directly, view it on GitHub<#277 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BDZKLAOKLSCG3BUUSS4KBDDYE43WLAVCNFSM6AAAAAA7AZT6E2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJWGEYTENZTHA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
CAUTION: External email. Do not click links or open attachments unless you recognize the sender and know the content is safe. Please forward all suspicious emails to ***@***.***
Follow this link to read our Privacy Statement<https://www.stryker.com/content/stryker/gb/en/legal/global-policy-statement.html/>
|
|
Hi.
Although the -1 is obviously a non-functional change, I tested again with the -1 as index, and it worked fine for me as expected, the utility widget is visible at the right side of the render widgets.
Best Regards
Trudbert
…________________________________
Von: Schwoerer, Trudbert ***@***.***>
Gesendet: Freitag, 17. November 2023 11:35
An: MITK/MITK ***@***.***>
Betreff: AW: [MITK/MITK] Improve render windows utility widgets (PR #277)
Hi.
Yes, I tested it with widgets at all sides and it worked, and the default position used in our application is at the right side, and this works fine.
Of cause, I tested it with the count() as index instead of -1, but this seems improbable as reason for this difference.
Best Regards
Trudbert
________________________________
Von: Stefan Dinkelacker ***@***.***>
Gesendet: Freitag, 17. November 2023 11:26
An: MITK/MITK ***@***.***>
Cc: Schwoerer, Trudbert ***@***.***>; Author ***@***.***>
Betreff: Re: [MITK/MITK] Improve render windows utility widgets (PR #277)
Sie erhalten nicht oft eine E-Mail von ***@***.*** Erfahren Sie, warum dies wichtig ist<https://aka.ms/LearnAboutSenderIdentification>
EXTERNAL EMAIL
Thanks for the contribution. We did a quick test and were able to show utility widgets as expected on the top (no regression) and bottom. On the left and right, though, widgets do not show up. Did you test it yourself with left or right and did it work for you?
—
Reply to this email directly, view it on GitHub<#277 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BDZKLAOKLSCG3BUUSS4KBDDYE43WLAVCNFSM6AAAAAA7AZT6E2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJWGEYTENZTHA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
CAUTION: External email. Do not click links or open attachments unless you recognize the sender and know the content is safe. Please forward all suspicious emails to ***@***.***
Follow this link to read our Privacy Statement<https://www.stryker.com/content/stryker/gb/en/legal/global-policy-statement.html/>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added possibility to add utility widgets at all sides of a render window.
QmitkRenderWindowWidget originally offered a method to add a utility widget at the top of a render window only. But MITK-based applications want to add widgets also on bottom, left and right.