Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestURLs coverage for project app #2229

Merged
merged 7 commits into from May 14, 2024
Merged

TestURLs coverage for project app #2229

merged 7 commits into from May 14, 2024

Conversation

bemoody
Copy link
Collaborator

@bemoody bemoody commented May 6, 2024

This adds test coverage for most of the URLs in the project app.

See the previous pull requests #1695, #1922, #2108 for background.

With this change, the bulk of site functionality should now be included in the TestURLs framework. A few small apps are left to add:

And a number of URLs across the site are skipped due to a lack of fixture data:

  • console
    • edit_submission
    • copyedit_submission
    • awaiting_authors
    • publish_submission
    • event_agreement_detail
    • event_agreement_delete
    • event_agreement_new_version
  • project
    • serve_document
    • published_project_request_access
  • search
    • redirect_challenge_project

Benjamin Moody added 7 commits May 6, 2024 11:11
Several views in this app have mandatory query parameters - these
views are accessed only by JavaScript, and return an HTML
fragment rather than a complete page.

A couple of views are not yet tested because the demo database
does not contain any UploadedDocument objects or any DataAccess
objects.  This should be fixed.
@tompollard tompollard merged commit 6f6406d into dev May 14, 2024
8 checks passed
@tompollard tompollard deleted the bm/project-testurls branch May 14, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants