Remove "no_phi" from "quality assurance results" #2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reviewing a project, the editor is asked to perform a series of "quality assurance" checks. In the "edit submission" form (console.forms.EditSubmissionForm), they must answer "yes", "no", or "undetermined" for each QA check. All answers must be "yes" in order to accept the project. One of the questions is "Is the project free of protected health information?" We don't want to give anyone the false impression that the editor has performed an exhaustive review or that this constitutes an "expert determination". In fact, the author is responsible for doing that review themselves before *uploading* the data. Therefore, keep this field among the questions included in EditSubmissionForm, but do not list it as a "quality assurance result" that is shown to the authors. Note that the public "quality assurance results" are generated by EditLog.set_quality_assurance_results, and they are included in email messages: - notification/templates/notification/email/accept_submission_notify.html - notification/templates/notification/email/reject_submission_notify.html - notification/templates/notification/email/revise_submission_notify.html and in the submission timeline: - project/templates/project/active_submission_timeline.html - project/templates/project/static_submission_timeline.html
|
Thanks for dealing with this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a project is submitted, the editor is asked "Is the project free of protected health information?"
We don't want to give anyone the false impression that we have performed an exhaustive review or that this constitutes an "expert determination". That is the author's job, not ours.
With this change, the question is still shown in the "Edit Submission" page (http://127.0.0.1:8000/console/submitted-projects/SHuKI1APLrwWCqxSQnSk/edit/). The editor is still required to answer "Yes" before the project can be accepted.
However, to reduce the possibilities for confusion, we won't include the question in the "standard quality assurance results", which are displayed in a few places:
Fixes issue #2218.