Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer Checklist for PRs & Issues #2212

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Rutvikrj26
Copy link
Contributor

@Rutvikrj26 Rutvikrj26 commented Apr 2, 2024

What:

This pull request is to open a discussion on what checks and guidelines can we introduce to ensure the pull requests are easy to go through and merge.

The discussion on this pull request will finally be incorporated into the Development.

Current Ideas:

  • A checklist for the developer to go through before marking the PR ready for review. This checklist can help accelerate the process of review for the maintainers.

Checklist:

  • Make sure you have tested your changes locally.
  • Make sure you have added the necessary test cases for your changes.
  • Make sure you have added the necessary documentation for your changes.
  • Added one-liner crisp comments describing the logic flow.
  • Added Docstrings to any new functions written.
  • Updated the README.md file with the necessary information.
  • Updated the Requirements.txt for any new dependencies added. (Auto-generated from Poetry using poetry export command)
  • Make sure you have added the necessary changes to the .env.example file.
  • A triaging system that divides the pull request into following categories - templates, views, models, admin-portal

…quests, and Issues for further enhancement and discussion.
@Rutvikrj26 Rutvikrj26 marked this pull request as ready for review April 7, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant