New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Hosts to Add Cohost (Re-Implemented) #2192
Conversation
Heyy @tompollard This is the re-implemented version for inviting cohosts, following the implementation of author invitations in projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Rutvikrj26 I prefer this to the previous implementation. I added a few comments inline.
The "invite co-hosts" button and the "outstanding co-host invitations" content are hidden away in their current location.
Is there a reason why you didn't put them at http://localhost:8000/events/ (following a similar layout to http://localhost:8000/projects/)?
physionet-django/notification/templates/notification/email/invite_cohost.html
Outdated
Show resolved
Hide resolved
That is a design decision I made to abstract out the related event invitations inside. @tompollard let me know your thoughts. We can change it if you feel it is better to have them on the generic events page. |
Thanks for explaining. Even for projects, outstanding tasks displayed at /projects refer to a specific project, so I don't think what we are doing with events are much different? My preference is to display the requests on the /events page (in the same way as projects), making it clear which event the task relates to. |
Hey @tompollard , thanks for adding your thoughts. I've switched the cohost invitation to show up on the event home page rather than the individual event page. |
… of the cohost invitation response form
Looks good, thanks! |
This Pull Request implements the feature to add cohosts for an event.
This PR is a continuation of the Cohost PR : #1925
The feature has been implemented in a similar fashion to how the author Invitation is handled currently.
Cohosts are supposed to be helper for hosts and can manage the participants(approving, rejecting participants)
To be cohost, one has to be first approved to join the event.
Worflow:
When a host opens the event page, the host will be able to see the option to invite a user as a cohost.
The person invited gets an email for cohost Invitation:
The person sees the invitation on the specific event's page.
When the person accepts, the host gets an email that the person has accepted the cohost invitation.
The form runs the check if the user is a participant in the event and prohibits inviting a random user as the last one implemented.