Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chg: [misp:event-type] Add description of the tags #281

Merged
merged 1 commit into from Apr 11, 2024
Merged

chg: [misp:event-type] Add description of the tags #281

merged 1 commit into from Apr 11, 2024

Conversation

Wachizungu
Copy link
Contributor

Mainly copied from dcso taxonomy, just very minor changes from myself.

@adulau
Copy link
Member

adulau commented Apr 11, 2024

Thanks for the PR. It would be better to use the description field? To avoid overflowing the UI with the expanded tag and the description.

@Wachizungu Wachizungu force-pushed the add-descriptions-to-misp-event-types branch from 089fdef to 9b02532 Compare April 11, 2024 15:27
@Wachizungu
Copy link
Contributor Author

Wachizungu commented Apr 11, 2024 •
edited

Ha, good point
Changed, still added a bit extra to expanded to make it more clear
version could be 13 (forgot to change it back before committing)

@adulau adulau merged commit 272192f into MISP:main Apr 11, 2024
5 checks passed
@adulau
Copy link
Member

adulau commented Apr 11, 2024

Awesome! Thank you for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Wachizungu @adulau