Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IP2Location.io expansion module #645

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Add IP2Location.io expansion module #645

merged 3 commits into from
Dec 12, 2023

Conversation

ip2location
Copy link
Contributor

  • Add IP2Location.io expansion module to help MISP users to query IP address using IP2Location.io API.

@adulau
Copy link
Member

adulau commented Dec 8, 2023

Thanks a lot for the contribution. A small questions what's the specific update in joesandbox library?

@ip2location
Copy link
Contributor Author

Thanks a lot for the contribution. A small questions what's the specific update in joesandbox library?

I followed other module when developing our expansion, is the update in joesandbox not compulsory? If yes I will then remove it.

@adulau
Copy link
Member

adulau commented Dec 8, 2023

I would just make a dedicated file if you need a library to not mix up with other tools. If you can update it, that would be great. Then I’ll merge it. Thanks a lot

@ip2location
Copy link
Contributor Author

I would just make a dedicated file if you need a library to not mix up with other tools. If you can update it, that would be great. Then I’ll merge it. Thanks a lot

Hi adulau,

I have removed it from the lib file.

@adulau adulau merged commit 3082e3c into MISP:main Dec 12, 2023
4 checks passed
@adulau
Copy link
Member

adulau commented Dec 12, 2023

Awesome! Thank you for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants