Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [pull] Fix pulling from remote server when analyst data is not s… #9605

Merged
merged 1 commit into from Mar 5, 2024

Conversation

JakubOnderka
Copy link
Contributor

What does it do?

Fixes #9601

Questions

  • Does it require a DB change?
  • Are you using it in production?
  • Does it require a change in the API (PyMISP for example)?

@iglocska
Copy link
Member

iglocska commented Mar 5, 2024

Nice catch!

@skalvaro
Copy link

skalvaro commented Mar 5, 2024

@JakubOnderka @iglocska I can confirm the fix seems to do the trick.
I applied the changes on the two files in the fix on top of v2.4.186 (708d181) and the pull job now successfully completes.

@iglocska
Copy link
Member

iglocska commented Mar 5, 2024

Excellent, thanks for the feedback @skalvaro - @JakubOnderka: Do you want to make any more changes or is it ready to be merged into develop?

@JakubOnderka JakubOnderka marked this pull request as ready for review March 5, 2024 15:44
@JakubOnderka JakubOnderka merged commit e79fc41 into MISP:develop Mar 5, 2024
1 check passed
@JakubOnderka JakubOnderka deleted the fix-pull-analyst branch March 5, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants