Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom galaxy cluster connector tag value #9178

Open
wants to merge 2 commits into
base: 2.4
Choose a base branch
from

Conversation

vincenzocaputo
Copy link
Contributor

What does it do?

Fix Issue: #8147

This pull request fixes the connector tag value of custom Galaxy Clusters, using the Cluster name rather then the UUID.

A check on the uniqueness of the connector tag was also added

Questions

  • Does it require a DB change?
  • Are you using it in production?
  • Does it require a change in the API (PyMISP for example)?

@mokaddem
Copy link
Contributor

Hey,
Thanks for your PR but this is the intended behavior. Any custom galaxy clusters have their connector tag with their UUID.
This is mainly for two reasons:

  1. Allow duplication of cluster (by forking or if you have different cluster-elements or relationships)
  2. To allow the synchronisation of attached tag without leaking the cluster if you're not allowed to see it

Once you have access to the cluster, the connector tag will be replaced by the actual cluster in the UI and API.

Does it make sense?

@mokaddem mokaddem added topic: galaxy topic: tagging R: wontfix Resolution: wontfix. This issue will not be fixed labels Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R: wontfix Resolution: wontfix. This issue will not be fixed topic: galaxy topic: tagging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants