Update data_loader.py #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the cf.dim=3, the data.shap in line 408 is (1, x, y, z)，so the data dimension is 4.But the original code passes a three-dimensional slice to data, which leads to an error this time.
|
Thanks so much for catching this. I merged your PR in the new commit. Sorry I could not do this directly on github, because for legal reasons this repository is mirrored from an internal phabricator repo. I need to figure out away to transfer PRs to phabricator, but am currently out of office, apologies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the cf.dim=3, the data.shap in line 408 is (1, x, y, z)，so the data dimension is 4.But the original code passes a three-dimensional slice to data, which causes errors