Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing methods and fixes #98

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

BirknerAlex
Copy link

This merge request contains following changes:

  • Added method to list memberships by organisation ids
  • Added method to show many tickets
  • Fixing search method for tickets.

Working search for tickets example:

search := fmt.Sprintf("brand:%v created>%v status<closed",
	c.Zendesk.BrandId,
	time.Now().Add(-time.Hour*48).Format("2006-01-02"),
)
result, err := zendeskClient.SearchTickets(search, &zendesk.ListOptions{
	Page:    0,
	PerPage: 100,
})

Copy link
Member

@eggman64 eggman64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your contribution!

Could you add tests for the two new methods. You can refer to the existing tests, or reach out in case you need some help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants