Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exp/3 pca seq #909

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Exp/3 pca seq #909

wants to merge 6 commits into from

Conversation

pablosmig
Copy link
Contributor

Experimenting with issue #860.
Non functional changes and breaks many tests.

@eurunuela
Copy link
Collaborator

Thank you @pablosmig! It's been fun to hack with you at Brainhack Donostia.

I'll finish the PR and share with the core developers team.

@eurunuela eurunuela self-assigned this Nov 25, 2022
@eurunuela
Copy link
Collaborator

@tsalo @jbteves @handwerkerd where do you think would be a good place to save the PCA variance explained plots that have the Kundu options incorporated?

@handwerkerd
Copy link
Member

I guess the core issue is that the kundu method isn't finding a local minimum so it's not actually a plot and there isn't even a threshold. The number of components retained would be an easy addition to desc-PCA_cross_component_metrics.json The other bit of info from kundu is which components are retained. That could either be a list in the same file or a new column with accepted & rejected in desc-PCA_metrics.tsv

Any other information that's looking for a home?

@dowdlelt
Copy link
Collaborator

dowdlelt commented Dec 2, 2022

Hopefully I'm not completely missing the point here, but this could be added to the existing plots - not as a threshold, but as maybe individual filled circles on the lines (or along the x-axis) indicating which components were selected. Such that the user can see that the three main methods would have picked threshold x, y, z and 'kundu' would have picked most of the components below that threshold and then a few beyond it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants