Refactor metrics.dependence module
#1088
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsalo
added
the
refactoring
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1088 +/- ##
=======================================
Coverage 89.80% 89.80%
=======================================
Files 26 26
Lines 3540 3542 +2
Branches 621 621
=======================================
+ Hits 3179 3181 +2
Misses 212 212
Partials 149 149 ☔ View full report in Codecov by Sentry. |
tsalo
commented
Apr 24, 2024
| @@ -119,7 +119,10 @@ def generate_metrics( | |||
| metric_maps = {} | |||
| if "map weight" in required_metrics: | |||
| LGR.info("Calculating weight maps") | |||
| metric_maps["map weight"] = dependence.calculate_weights(data_optcom, mixing) | |||
| metric_maps["map weight"] = dependence.calculate_weights( | |||
| data_optcom=data_optcom, | |||
There was a problem hiding this comment.
Related to #1086 (comment) we use data_oc in other places. I'd like to commit to one or the other and make the variable names consistent between this PR and #1086.
There was a problem hiding this comment.
I personally like data_optcom better.
There was a problem hiding this comment.
That works for me. @handwerkerd do you have an opinion on this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes none.
Changes proposed in this pull request: