Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update figure-generating notebook #1074

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Apr 14, 2024

Closes none. I figure that we've made a bunch of changes to the codebase that should be reflected in the documentation (e.g., the adaptive mask).

Changes proposed in this pull request:

  • Update the walkthrough notebook to follow the current output filename convention.
  • Update the denoising approach page's figures.

Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.91%. Comparing base (0f6cbe1) to head (5f6354b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1074   +/-   ##
=======================================
  Coverage   89.91%   89.91%           
=======================================
  Files          26       26           
  Lines        3621     3621           
  Branches      629      629           
=======================================
  Hits         3256     3256           
  Misses        214      214           
  Partials      151      151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo added the documentation issues related to improving documentation for the project label Apr 15, 2024
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a voxel that actually has a more interesting signal development across echoes than the old one, which was really just the checkerboard signal across all of the echoes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this might be interesting to show the adaptive mask.

Copy link
Collaborator

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation issues related to improving documentation for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants