Correct: Improved backlight handling and charging #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tasks can run. It does not loop on itself any more. Add better support for charging mode.
|
Thanks a lot! It works! Just checked with the example from my PR - now seconds counter keeps going while BL is off in inactivity... ) |
|
@antimix, you always change and check _inactive in parellel with _backlight_off. Any special reason to keep two vars? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now when back-lite mode is on (LCD is off) , other tasks can run.
The back light button waiting cycle event does not loop anymore preventing other scheduled tasks to run.
Add better support for charging mode.