-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LWDEV-8274 Use Context in multilimit order #263
base: master
Are you sure you want to change the base?
Conversation
# Conflicts: # src/main/kotlin/com/lykke/matching/engine/services/MultiLimitOrderService.kt # src/test/kotlin/com/lykke/matching/engine/config/TestApplicationContext.kt # src/test/kotlin/com/lykke/matching/engine/incoming/preprocessor/impl/SingleLimitOrderPreprocessorTest.kt # src/test/kotlin/com/lykke/matching/engine/utils/MessageBuilder.kt
# Conflicts: # src/dist/cfg/log4j.properties # src/main/kotlin/com/lykke/matching/engine/services/MultiLimitOrderService.kt # src/test/kotlin/com/lykke/matching/engine/config/TestApplicationContext.kt # src/test/kotlin/com/lykke/matching/engine/config/TestExecutionContext.kt # src/test/kotlin/com/lykke/matching/engine/performance/AbstractPerformanceTest.kt
src/main/kotlin/com/lykke/matching/engine/daos/context/MultilimitOrderContext.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/lykke/matching/engine/incoming/parsers/impl/MultilimitOrderContextParser.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/lykke/matching/engine/incoming/parsers/impl/MultilimitOrderContextParser.kt
Outdated
Show resolved
Hide resolved
...n/kotlin/com/lykke/matching/engine/incoming/preprocessor/impl/MultilimitOrderPreprocessor.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/lykke/matching/engine/services/MultiLimitOrderService.kt
Outdated
Show resolved
Hide resolved
...n/kotlin/com/lykke/matching/engine/incoming/preprocessor/impl/MultilimitOrderPreprocessor.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/lykke/matching/engine/services/MultiLimitOrderService.kt
Outdated
Show resolved
Hide resolved
...lin/com/lykke/matching/engine/incoming/preprocessor/impl/SingleLimitOrderPreprocessorTest.kt
Show resolved
Hide resolved
src/test/kotlin/com/lykke/matching/engine/services/ClientMultiLimitOrderTest.kt
Show resolved
Hide resolved
return false | ||
} | ||
|
||
return true | ||
} | ||
|
||
fun writeResponse(messageWrapper: MessageWrapper, assetPairId: String, status: MessageStatus, message: String? = null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is needed to override parrent writeResponse
because it is invoked from the parent class and MultiOrderResponse must be returned always (I think it is not a problem not to return assetPairId in those invokes)
@RunWith(SpringRunner::class) | ||
@SpringBootTest(classes = [(TestApplicationContext::class)]) | ||
@DirtiesContext(classMode = DirtiesContext.ClassMode.AFTER_EACH_TEST_METHOD) | ||
class MultilimitOrerPreprocessorTest: AbstractTest() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong name
@@ -40,13 +43,21 @@ class MultilimitOrderPreprocessor(private val messageProcessingStatusHolder: Mes | |||
if (fatallyInvalidValidationResult != null) { | |||
logger.error("Fatal validation error occurred, ${fatallyInvalidValidationResult.message} " + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently this log is still not displayed properly due to context.multiLimitOrder.orders
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
# Conflicts: # src/test/kotlin/com/lykke/matching/engine/performance/AbstractPerformanceTest.kt
# Conflicts: # src/test/kotlin/com/lykke/matching/engine/services/LimitOrderMassCancelServiceTest.kt
# Conflicts: # src/main/kotlin/com/lykke/matching/engine/services/validators/business/impl/LimitOrderBusinessValidatorImpl.kt # src/main/kotlin/com/lykke/matching/engine/services/validators/business/impl/StopOrderBusinessValidatorImpl.kt # src/main/kotlin/com/lykke/matching/engine/services/validators/common/OrderValidationUtils.kt # src/test/kotlin/com/lykke/matching/engine/config/TestApplicationContext.kt # src/test/kotlin/com/lykke/matching/engine/performance/AbstractPerformanceTest.kt # src/test/kotlin/com/lykke/matching/engine/services/validator/business/LimitOrderBusinessValidatorTest.kt # src/test/kotlin/com/lykke/matching/engine/utils/MessageBuilder.kt
No description provided.