-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Axis conversion for TransientSpec #205
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
===========================================
- Coverage 100.00% 99.48% -0.52%
===========================================
Files 12 12
Lines 556 578 +22
===========================================
+ Hits 556 575 +19
- Misses 0 3 +3 ☔ View full report in Codecov by Sentry. |
>>> S1.to_invcm(laser=325) | ||
""" | ||
|
||
def to_invcm_relative(self, laser=None, inplace=True, jacobian=False): |
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns Note
1f99632
to
7927533
Compare
c5c1ee9
to
20c32b3
Compare
3b2fc4b
to
0d2c439
Compare
0a0e021
to
330cc47
Compare
# along with LumiSpy. If not, see <https://www.gnu.org/licenses/#GPL>. | ||
|
||
import numpy as np | ||
import pytest |
Check notice
Code scanning / CodeQL
Unused import Note
import pytest | ||
|
||
from lumispy.signals import LumiSpectrum, LumiTransient, LumiTransientSpectrum | ||
from hyperspy._signals.signal2d import Signal2D |
Check notice
Code scanning / CodeQL
Unused import Note
|
||
from lumispy.signals import LumiSpectrum, LumiTransient, LumiTransientSpectrum | ||
from hyperspy._signals.signal2d import Signal2D | ||
from numpy.testing import assert_allclose |
Check notice
Code scanning / CodeQL
Unused import Note
5882277
to
9b54af6
Compare
Description of the change
Move axis conversion code to
CommonLuminescence
class to make it available toLuminescenceTransientSpectrum
signals.Handle inheritance for slicing of
LuminescenceTransientSpectrum
:signal_type = 'TransientSpec'
(classTransientSpectrumCasting
)TransientSpec
is initialized in 1D withaxes_manager[-1].units
being a time unit, switch toLumiTransient
class, otherwise switch toLuminescence
classProgress of the PR