Implement adding data from config file #934
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CBroz1
reviewed
Apr 17, 2024
There was a problem hiding this comment.
Thanks for working on this!
I started on common_subject and worked up, so the 'why' might be in the later comments. All my comments are along the lines of "This old part of spyglass doesn't do this python thing that I think we'd be better off if we did". What you've got so far looks like it would work perfectly well, but I'm cutting down lines of code in my suggestions
Co-authored-by: Chris Brozdowski <CBrozdowski@yahoo.com>
edeno
reviewed
Apr 25, 2024
| @@ -252,13 +252,16 @@ class CameraDevice(SpyglassMixin, dj.Manual): | |||
| """ | |||
|
|
|||
| @classmethod | |||
| def insert_from_nwbfile(cls, nwbf): | |||
| def insert_from_nwbfile(cls, nwbf, config): | |||
There was a problem hiding this comment.
config should probably be optional here since not everyone will have one.
|
@calderast what is the status of this PR? is it mostly good to go (aside from the change requested above) or are you still working on things? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement adding data from config file
Allows users to specify Institution, Lab, LabMember, Subject, and CameraDevice information for an nwb file in the associated config file.
Checklist:
CITATION.cffCHANGELOG.md