Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OFFI-37: Adding SignInDirectlyAndGoToAdminRelativeUrlAsync extension method #367

Merged
merged 4 commits into from May 15, 2024
Merged

OFFI-37: Adding SignInDirectlyAndGoToAdminRelativeUrlAsync extension method #367

merged 4 commits into from May 15, 2024

Conversation

porgabi
Copy link
Member

@porgabi porgabi commented May 10, 2024 •
edited by jira bot

sarahelsaig
sarahelsaig approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@sarahelsaig sarahelsaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I question why we need all these SignInDirectlyAnd... methods in the first place, but it if we must have SignInDirectlyAndGoToRelativeUrlAsync then it's good to add its admin counterpart for consistency.

@Piedone Piedone changed the title OFFI-37: Adding extension method OFFI-37: Adding SignInDirectlyAndGoToAdminRelativeUrlAsync extension method May 15, 2024
@sarahelsaig sarahelsaig merged commit 7bb8d63 into dev May 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahelsaig sarahelsaig sarahelsaig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@porgabi @sarahelsaig