LMBQ-329: Adding Slick carousel #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DemeSzabolcs
requested changes
Apr 29, 2024
| const $carouselArrows = $carouselContainer.find(".slickCarousel__arrows"); | ||
|
|
||
| $carousel.on("init", () => { | ||
| // Carousel initializes elements with empty id attributes, which triggers HTML validation errors. |
There was a problem hiding this comment.
Is this always the case? Can't you add ID-s to the elements, or preventing adding the id-s?
If it's always added and there is no way to fill them up (so they will be always empty), then open an issue about this here: https://github.com/kenwheeler/slick
Lombiq.UIKit.Tests.UI/Extensions/TestCaseUITestContextExtensions.cs
Outdated
Show resolved
Hide resolved
# Conflicts: # Lombiq.UIKit/Lombiq.UIKit.csproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LMBQ-329