Add hot reload workaround for skhd service #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forces reload of the config at postActivation as upstream doesn't suppport hot reloading for symlinks yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #333, until koekeishiya/skhd#342 is solved.
Changes:
the
lognamepkg should be present in macos by default, tho I usedpkgs.coreutilsto ensure immutability (if for any reason the machine doesn't have the pkg etc).More info here: #333 (comment)
Question about when the service changes:
I didn't check if the config is empty as someone can go from a config to an empty one.
But at that point also the service in launchd changes.