Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #921

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update README.md #921

wants to merge 4 commits into from

Conversation

jakubsvec001
Copy link

ADD a note about adding '/run/current-system/sw/bin' to path in order to access the 'darwin-rebuild' command if the command is not found

ADD a note about adding '/run/current-system/sw/bin' to path in order to access the 'darwin-rebuild' command if the command is not found
@jakubsvec001
Copy link
Author

i'm not sure why 'install-against-stable' failed, since I only updated the README.md...

README.md Outdated
Comment on lines 141 to 142
NOTE: if the 'darwin-rebuild' command is not found, you will need to add a path to your ~/.bashrc or ~/.zshrc file. In the file, add: `export PATH=/run/current-system/sw/bin:$PATH`

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should replace the one on 135

Suggested change
NOTE: if the 'darwin-rebuild' command is not found, you will need to add a path to your ~/.bashrc or ~/.zshrc file. In the file, add: `export PATH=/run/current-system/sw/bin:$PATH`
After installing, restarting your computer should make `darwin-rebuild` available in your `PATH` to apply changes to your system:

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Enzime I've incorporated your suggestion


```bash
darwin-rebuild switch --flake ~/.config/nix-darwin
```

> NOTE: if the 'darwin-rebuild' command is not found after installation, you will need to add a path to your shell configuration (f.e. the ~/.bashrc or ~/.zshrc file).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> NOTE: if the 'darwin-rebuild' command is not found after installation, you will need to add a path to your shell configuration (f.e. the ~/.bashrc or ~/.zshrc file).

If nix-darwin is installed correctly then the user shouldn't have this issue

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Enzime I understand the reason for removing it, however the inclusion of guardrails can make a program more approachable for newbies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants